Support transactions #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The disconnect() method has been labeled as 'async' even though awaiting on it would guarantee only Zookeeper disconnect. For Kafka disconnect on the other side, one needs to wait for callback invokation. * I have changed the prototype of the method to better match this, now the user needs to provide and wait for callback invokation.
YordanPavlov
requested review from
kalkov,
IvanIvanoff,
apozdeyev,
tzanko-matev and
antisaa
…n Dockerfile removed.
kalkov
approved these changes
Apr 21, 2021
IvanIvanoff
reviewed
Apr 21, 2021
IvanIvanoff
reviewed
Apr 21, 2021
IvanIvanoff
reviewed
Apr 21, 2021
IvanIvanoff
reviewed
Apr 21, 2021
IvanIvanoff
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Kafka transaction support to san-exporter. We need this to provide 'exactly once' semantic.
The bigger work related with this PR has been happening in Node-rdkafka. The library is a wrapper over Librdkafka which supports transactions, but that support needs to be brought to JS. I have been trying to do this in this PR:
Blizzard/node-rdkafka#881
If you feel like doing so, please also comment there. My PR is still not accepted so for now we use an NPM from our own NPM repo:
@santiment-network/node-rdkafka.Also in this PR I have done some fixes:
P.S. I am tagging more people for this PR, because we have bigger plans for san-exporter. The idea is for it to gradually absorb all other exporters into a single higher quality repository which people outside of Santiment would use. So any feedback is welcome.